Fix task ID inconsistency in application suspend.c
#52
Conversation
The introduction of the logger task in previous commits changed the task creation order, which caused inconsistencies in fixed task ID assignments. This commit binds the task ID directly from the creation parameter, ensuring deterministic and correct ID assignment regardless of task creation order.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Are we able to identify specifically which commits are referred to as 'previous commits' in the description? |
Refer to #41 mo_task_spawn() is called in mo_logger_init() and mo_logger_init() is called before the creation of costumer applications, which causes task ID error used in |
|
Thanks. I think it would be worthwhile to include these in the description. That way, it will be easier for both current reviewers and future readers to track down the code that introduced the issue we are fixing. |
Thanks for your feedback! |
2 participants
The introduction of the logger task in previous commits changed the task creation order, which caused inconsistencies in fixed task ID assignments.
This commit binds the task ID directly from the creation parameter, ensuring deterministic and correct ID assignment regardless of task creation order.
Summary by cubic
Fixes task ID mismatches in suspend.c by using the IDs returned from mo_task_spawn instead of hardcoded indices. This makes suspend/resume deterministic even if task creation order changes (e.g., after adding the logger task).
Written for commit c514fde. Summary will update automatically on new commits.